Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Small fix on adding a new parent using the tab #1732

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Oct 23, 2024

Proposed changes

  • Small fix on adding a new parent using the tab

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.15%. Comparing base (8768b3e) to head (899b1ca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1732   +/-   ##
=========================================
  Coverage     33.15%   33.15%           
  Complexity     1599     1599           
=========================================
  Files           561      561           
  Lines         14646    14646           
  Branches        895      895           
=========================================
  Hits           4856     4856           
  Misses         9559     9559           
  Partials        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit 8981a4e into master Oct 23, 2024
7 checks passed
@Dimfacion Dimfacion deleted the bugfix/fix-adding-parent branch October 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants