Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Properly generate types for chaining injects #1830

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Nov 8, 2024

Proposed changes

  • Properly generate types for chaining injects

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (8eabb12) to head (ed5041f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1830      +/-   ##
============================================
- Coverage     32.06%   32.02%   -0.04%     
  Complexity     1609     1609              
============================================
  Files           561      561              
  Lines         16861    16882      +21     
  Branches        984      984              
============================================
  Hits           5406     5406              
- Misses        11211    11232      +21     
  Partials        244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit e396e68 into master Nov 12, 2024
7 checks passed
@SamuelHassine SamuelHassine deleted the bugfix/fix_dependency branch January 2, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants