Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend|backend]Show prerequisites info in atomic testing #1858

Closed
wants to merge 27 commits into from

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 self-assigned this Nov 14, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 14, 2024
@johanah29 johanah29 force-pushed the issue/1518-inject-details branch from 7260e52 to 33b5e76 Compare November 15, 2024 15:46
@johanah29 johanah29 changed the title [frontend]Show prerequisites info in atomic testing [frontend|backend]Show prerequisites info in atomic testing Nov 19, 2024
@guillaumejparis guillaumejparis changed the title [frontend|backend]Show prerequisites info in atomic testing [frontend/backend] Show prerequisites info in atomic testing (#1856) Nov 19, 2024
@johanah29 johanah29 changed the title [frontend/backend] Show prerequisites info in atomic testing (#1856) [frontend|backend]Show prerequisites info in atomic testing Nov 25, 2024
@johanah29 johanah29 force-pushed the issue/1518-inject-details branch 3 times, most recently from c01b635 to 4f87c8a Compare November 29, 2024 14:23
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 11.68831% with 204 lines in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (5308c84) to head (6f27537).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../src/main/java/io/openbas/utils/PayloadMapper.java 1.16% 85 Missing ⚠️
...pi/src/main/java/io/openbas/utils/InjectUtils.java 0.00% 43 Missing ⚠️
.../rest/atomic_testing/form/StatusPayloadOutput.java 0.00% 28 Missing ⚠️
...ation/V3_49__Update_Commands_In_Inject_Status.java 34.21% 24 Missing and 1 partial ⚠️
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 11 Missing ⚠️
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 3 Missing ⚠️
...mic_testing/form/AtomicInjectorContractOutput.java 75.00% 1 Missing and 1 partial ⚠️
...est/injector_contract/InjectorContractService.java 33.33% 0 Missing and 2 partials ⚠️
.../java/io/openbas/service/AtomicTestingService.java 0.00% 2 Missing ⚠️
...enbas/injectors/caldera/client/model/Executor.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1858      +/-   ##
============================================
- Coverage     33.56%   33.35%   -0.21%     
- Complexity     1665     1685      +20     
============================================
  Files           572      578       +6     
  Lines         16695    17014     +319     
  Branches        970     1004      +34     
============================================
+ Hits           5603     5675      +72     
- Misses        10838    11081     +243     
- Partials        254      258       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 marked this pull request as ready for review November 29, 2024 14:32
Copy link
Contributor

@heditar heditar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments about the code structure, I didn't test the code yet

@johanah29 johanah29 force-pushed the issue/1518-inject-details branch from 1156c7b to d09fe2f Compare December 3, 2024 09:45
Copy link
Contributor

@savacano28 savacano28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some errors frontend side

@johanah29 johanah29 force-pushed the issue/1518-inject-details branch 3 times, most recently from 8de5930 to 60d8044 Compare December 4, 2024 08:49
@johanah29 johanah29 requested a review from savacano28 December 4, 2024 16:55
@johanah29 johanah29 force-pushed the issue/1518-inject-details branch from 60d8044 to 4353f33 Compare December 9, 2024 10:07
@johanah29 johanah29 closed this Dec 10, 2024
@johanah29 johanah29 deleted the issue/1518-inject-details branch December 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants