-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend|backend]Show prerequisites info in atomic testing #1858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
use to identify PR from the Filigran team
label
Nov 14, 2024
johanah29
force-pushed
the
issue/1518-inject-details
branch
from
November 15, 2024 15:46
7260e52
to
33b5e76
Compare
johanah29
changed the title
[frontend]Show prerequisites info in atomic testing
[frontend|backend]Show prerequisites info in atomic testing
Nov 19, 2024
guillaumejparis
changed the title
[frontend|backend]Show prerequisites info in atomic testing
[frontend/backend] Show prerequisites info in atomic testing (#1856)
Nov 19, 2024
johanah29
changed the title
[frontend/backend] Show prerequisites info in atomic testing (#1856)
[frontend|backend]Show prerequisites info in atomic testing
Nov 25, 2024
johanah29
force-pushed
the
issue/1518-inject-details
branch
3 times, most recently
from
November 29, 2024 14:23
c01b635
to
4f87c8a
Compare
savacano28
reviewed
Nov 29, 2024
heditar
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments about the code structure, I didn't test the code yet
openbas-api/src/main/java/io/openbas/service/AtomicTestingService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/service/AtomicTestingService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/injectors/caldera/CalderaExecutor.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/service/AtomicTestingService.java
Outdated
Show resolved
Hide resolved
johanah29
force-pushed
the
issue/1518-inject-details
branch
from
December 3, 2024 09:45
1156c7b
to
d09fe2f
Compare
savacano28
reviewed
Dec 3, 2024
openbas-api/src/main/java/io/openbas/utils/AtomicTestingUtils.java
Outdated
Show resolved
Hide resolved
heditar
approved these changes
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
openbas-api/src/main/java/io/openbas/migration/V3_49__Update_Commands_In_Inject_Status.java
Show resolved
Hide resolved
savacano28
reviewed
Dec 3, 2024
openbas-api/src/main/java/io/openbas/rest/atomic_testing/form/PayloadOutputDto.java
Outdated
Show resolved
Hide resolved
savacano28
reviewed
Dec 3, 2024
openbas-api/src/main/java/io/openbas/utils/AtomicTestingUtils.java
Outdated
Show resolved
Hide resolved
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
openbas-model/src/main/java/io/openbas/database/model/AttackPatternSimple.java
Outdated
Show resolved
Hide resolved
savacano28
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some errors frontend side
johanah29
force-pushed
the
issue/1518-inject-details
branch
3 times, most recently
from
December 4, 2024 08:49
8de5930
to
60d8044
Compare
johanah29
force-pushed
the
issue/1518-inject-details
branch
from
December 9, 2024 10:07
60d8044
to
4353f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1856