Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] catch error when execution fails for some asset (#1863) #1864

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

guillaumejparis
Copy link
Member

Close #1863

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (7b2fa64) to head (42dc439).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1864   +/-   ##
=========================================
  Coverage     33.04%   33.04%           
  Complexity     1653     1653           
=========================================
  Files           571      571           
  Lines         16766    16766           
  Branches        972      971    -1     
=========================================
  Hits           5540     5540           
  Misses        10979    10979           
  Partials        247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dimfacion Dimfacion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well played

@guillaumejparis guillaumejparis merged commit 255265f into master Nov 15, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/1863 branch November 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Injects execution blocked when an execution fails for a particular asset
3 participants