Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Close entity manager #1883

Closed
wants to merge 1 commit into from

Conversation

savacano28
Copy link
Contributor

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 marked this pull request as ready for review November 18, 2024 09:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 41.78082% with 85 lines in your changes missing coverage. Please review.

Project coverage is 33.03%. Comparing base (d20c8e3) to head (7b569c6).

Files with missing lines Patch % Lines
.../src/main/java/io/openbas/service/TeamService.java 0.00% 30 Missing ⚠️
.../main/java/io/openbas/rest/user/PlayerService.java 0.00% 18 Missing ⚠️
...n/java/io/openbas/service/InjectSearchService.java 48.38% 13 Missing and 3 partials ⚠️
.../asset_group/AssetGroupCriteriaBuilderService.java 50.00% 12 Missing and 3 partials ⚠️
...openbas/rest/exercise/service/ExerciseService.java 84.21% 0 Missing and 3 partials ⚠️
...est/injector_contract/InjectorContractService.java 83.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1883      +/-   ##
============================================
- Coverage     33.04%   33.03%   -0.02%     
  Complexity     1653     1653              
============================================
  Files           571      571              
  Lines         16766    16784      +18     
  Branches        971      980       +9     
============================================
+ Hits           5540     5544       +4     
- Misses        10979    10989      +10     
- Partials        247      251       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return execution(query, this.mapper);
} finally {
if (entityManager != null && entityManager.isOpen()) {
entityManager.close();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you! I close it! :)

@savacano28 savacano28 closed this Nov 18, 2024
@savacano28 savacano28 deleted the bugfix/close-session-entity-manager branch November 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants