Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Fix editing challenge #1886

Merged
merged 5 commits into from
Nov 19, 2024
Merged

[backend/frontend] Fix editing challenge #1886

merged 5 commits into from
Nov 19, 2024

Conversation

RomuDeuxfois
Copy link
Member

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 18, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.30%. Comparing base (d20c8e3) to head (7324127).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...io/openbas/rest/challenge/form/ChallengeInput.java 0.00% 8 Missing ⚠️
...n/java/io/openbas/rest/challenge/ChallengeApi.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1886      +/-   ##
============================================
+ Coverage     33.04%   33.30%   +0.26%     
- Complexity     1653     1676      +23     
============================================
  Files           571      571              
  Lines         16766    16764       -2     
  Branches        971      974       +3     
============================================
+ Hits           5540     5584      +44     
+ Misses        10979    10933      -46     
  Partials        247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@isselparra isselparra self-requested a review November 19, 2024 13:23

@AfterAll
void afterAll() {
this.scenarioRepository.deleteById(SCENARIO_ID);
this.scenarioService.deleteScenario(SCENARIO_ID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why do we need to delete the Scenario with the service instead of the repository?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to remove scenarioRepository from the class.
But, it's maybe not a good shot ?

@isselparra
Copy link
Contributor

TEST OK

  • Creation of Challenge -> OK, No regression
  • Update of a Challenge -> OK, fix works

I have a question regarding the values of Score and Max number of attempts, is it normal that I'm able to set negative numbers?
I updated my Challenge with a -0.43 Score and a -42 as Max number of attempts
Screenshot from 2024-11-19 16-14-38

@RomuDeuxfois
Copy link
Member Author

TEST OK

  • Creation of Challenge -> OK, No regression
  • Update of a Challenge -> OK, fix works

I have a question regarding the values of Score and Max number of attempts, is it normal that I'm able to set negative numbers? I updated my Challenge with a -0.43 Score and a -42 as Max number of attempts Screenshot from 2024-11-19 16-14-38

Taking care of it

Ready for a second round

@isselparra
Copy link
Contributor

TEST OK

  • Creation of Challenge -> OK, No regression
  • Update of a Challenge -> OK, fix works

Just a last question, to be sure, a Score can only be an integer ? In the DB it's indicated as double precision

@RomuDeuxfois RomuDeuxfois merged commit 8e33d5d into master Nov 19, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1758 branch November 19, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when editing a challenge
2 participants