-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Fix editing challenge #1886
Conversation
RomuDeuxfois
commented
Nov 18, 2024
- Closes Error when editing a challenge #1758
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
============================================
+ Coverage 33.04% 33.30% +0.26%
- Complexity 1653 1676 +23
============================================
Files 571 571
Lines 16766 16764 -2
Branches 971 974 +3
============================================
+ Hits 5540 5584 +44
+ Misses 10979 10933 -46
Partials 247 247 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
||
@AfterAll | ||
void afterAll() { | ||
this.scenarioRepository.deleteById(SCENARIO_ID); | ||
this.scenarioService.deleteScenario(SCENARIO_ID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why do we need to delete the Scenario with the service instead of the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to remove scenarioRepository from the class.
But, it's maybe not a good shot ?
openbas-api/src/main/java/io/openbas/rest/challenge/form/ChallengeInput.java
Outdated
Show resolved
Hide resolved
TEST OK
Just a last question, to be sure, a Score can only be an integer ? In the DB it's indicated as |