Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Layout of inject lists is not correct in create injects Issue/1842 #2095

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Dec 18, 2024

Proposed changes

  • In the CreateInject screen: Removed the secondary action in the header to fix the layout
  • In the CreateInject screen: Added margin between the Attack patterns
  • In the TestInject screen: removed the class from the ListItem as it was added to the ListButton also which was adding 2 times the padding

Before
Screenshot 2024-12-18 163359

After
Screenshot 2024-12-19 153841

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@heditar heditar added the filigran team use to identify PR from the Filigran team label Dec 18, 2024
@heditar heditar changed the title Issue/1842 Layout of inject lists is not correct in create injects Issue/1842 Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.77%. Comparing base (fece7c2) to head (be006ae).
Report is 61 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2095      +/-   ##
============================================
+ Coverage     33.75%   35.77%   +2.01%     
- Complexity     1682     1912     +230     
============================================
  Files           574      593      +19     
  Lines         16798    18384    +1586     
  Branches        995     1206     +211     
============================================
+ Hits           5671     6576     +905     
- Misses        10863    11488     +625     
- Partials        264      320      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 self-requested a review December 19, 2024 11:29
@heditar heditar changed the title Layout of inject lists is not correct in create injects Issue/1842 [frontend] Layout of inject lists is not correct in create injects Issue/1842 Dec 19, 2024
@heditar heditar merged commit 275dc01 into master Dec 19, 2024
7 checks passed
@heditar heditar deleted the issue/1842 branch December 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout of inject lists is not correct in create injects
2 participants