Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add enabled property to injectInput in order to create inje… #2099

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Dec 18, 2024

…cts with a disable status

Proposed changes

  • Add param to injectInput in order to create inject with a enable/disable status

PR linked:
OCTI: OpenCTI-Platform/opencti#9250
DOC: OpenBAS-Platform/docs#72

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Dec 18, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Dec 18, 2024
@savacano28 savacano28 marked this pull request as ready for review December 18, 2024 17:18
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.12%. Comparing base (8cb6667) to head (7a9fc42).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2099   +/-   ##
=========================================
  Coverage     35.11%   35.12%           
  Complexity     1418     1418           
=========================================
  Files           535      535           
  Lines         16187    16189    +2     
  Branches       1037     1037           
=========================================
+ Hits           5684     5686    +2     
  Misses        10209    10209           
  Partials        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit b6df3e4 into master Dec 23, 2024
7 checks passed
@savacano28 savacano28 deleted the issue/2043 branch December 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCTI x OBAS Add placeholder to TTP that could not be generated
2 participants