Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] adding TagRule apis/repo Issue/1998 #2122

Merged
merged 36 commits into from
Jan 3, 2025
Merged

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Dec 23, 2024

Proposed changes

  • Creating the new TagRule apis/repo

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@heditar heditar added the filigran team use to identify PR from the Filigran team label Dec 23, 2024
@heditar heditar marked this pull request as draft December 24, 2024 08:13
@heditar heditar changed the base branch from master to release/1.11.0 December 24, 2024 08:24
@heditar heditar changed the title [not ready for review yet] Issue/1998 [backendt] adding TagRule apis/repo Issue/1998 Dec 24, 2024
@heditar heditar changed the title [backendt] adding TagRule apis/repo Issue/1998 [backend] adding TagRule apis/repo Issue/1998 Dec 24, 2024
@heditar heditar marked this pull request as ready for review December 24, 2024 09:56
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.00%. Comparing base (493f508) to head (1fa9a8d).
Report is 1 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...c/main/java/io/openbas/service/TagRuleService.java 93.54% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2122      +/-   ##
====================================================
+ Coverage             35.78%   36.00%   +0.22%     
- Complexity             1453     1479      +26     
====================================================
  Files                   540      544       +4     
  Lines                 16486    16543      +57     
  Branches               1056     1056              
====================================================
+ Hits                   5899     5957      +58     
+ Misses                10287    10286       -1     
  Partials                300      300              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heditar heditar merged commit f257e8e into release/1.11.0 Jan 3, 2025
6 checks passed
@heditar heditar deleted the issue/1998 branch January 3, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants