Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Change "Add teams..." dialog into "Modify teams..." and alter behaviour (#2112) #2125

Closed
wants to merge 22 commits into from

Conversation

antoinemzs
Copy link
Contributor

Proposed changes

  • "Add teams..." controls in Inject definitions is changed to "Modify teams"
  • The Modify teams dialog allows for adding or removing teams to/from inject
  • Allowed team list is scoped down to the teams added to a scenario/simulation accordingly
    • If no teams were added to a scenario or simulation, no teams are available to add to injects

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.12%. Comparing base (b6df3e4) to head (111b637).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2125   +/-   ##
=========================================
  Coverage     35.12%   35.12%           
  Complexity     1418     1418           
=========================================
  Files           535      535           
  Lines         16189    16189           
  Branches       1037     1037           
=========================================
  Hits           5686     5686           
  Misses        10209    10209           
  Partials        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois changed the base branch from master to release/1.11.0 December 26, 2024 16:23
renovate bot and others added 22 commits December 26, 2024 17:25
Co-authored-by: Romuald Lemesle <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Romuald Lemesle <[email protected]>
Co-authored-by: Guillaume Paris <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying targets in an inject is not working properly
5 participants