Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix python injector missing callback route (#2230) #2229

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

guillaumejparis
Copy link
Member

Proposed changes

  • fix python injector missing callback route

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 17, 2025
@guillaumejparis guillaumejparis linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (dae4558) to head (d8505a3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/rest/inject/InjectApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2229      +/-   ##
============================================
- Coverage     32.70%   32.70%   -0.01%     
  Complexity     1515     1515              
============================================
  Files           582      582              
  Lines         18037    18038       +1     
  Branches       1156     1156              
============================================
  Hits           5899     5899              
- Misses        11874    11875       +1     
  Partials        264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis guillaumejparis changed the title [backend] fix python injector missing callback route [backend] fix python injector missing callback route (#2230) Jan 17, 2025
@guillaumejparis guillaumejparis merged commit 9eed9a9 into master Jan 17, 2025
7 checks passed
@guillaumejparis guillaumejparis deleted the fix-missing-inejctor-callback-route branch January 17, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http injector cannot callback openbas
2 participants