fix: use Lead Style from MP tick import instead of Style #1259
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also coerce imported fields from MP into the set of possible values defined in OpenBeta/openbeta-graphql#444? That could also be a separate PR, but it is necessary in order to make the change to allowable types |
Vichy97
approved these changes
Jan 23, 2025
set style and attemptType to null instead of N/A if absent
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
8b3c22d to
9826bc3
Compare
|
Update: I allowed null for both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
title: 'correctly import attemptStyle from MP tick import'
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
When importing ticks from Mountain Project, the
attemptStylefield was being populated with theStylefield from MP. It should use theLead Stylefield instead.Related Issues
Issue #
The issue was created in openbeta-graphql, but the code is in open-tacos.
OpenBeta/openbeta-graphql#424
What this PR achieves
When converting a MPTick to a Tick object, set
attemptStyleon Tick to be the value fromLead Styleon MPTick (if present).Notes
I don't see an obvious way to write tests for this. everything in tests/ticks.ts mocks out Tick objects after the conversion from MPTick has already happened, so a new test would probably have to be more of an end-to-end tests.