-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analyse_freenrg to use pymbar 4 #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of all of these changes. Thanks for updating the requirements_bss and try_import lines to the latest versions :-)
@jmichel80 - is this something you are happy to merge? Do you want to run more tests? This is a change in functionality, so would go into |
Could we support both pymbar versions easily for the time being ? The default would be pymbar 4 but it would make it possible to revert to using BSS in an environment with pymbar3 in case we run into issues. |
@jmichel80 I've updated the code to be compatible with either version of pymbar. I've tested with pymbar greater than, and less than 4 on the same data (bound vanish leg of a MIF ABFE calculation) and got identical results. |
Thanks @fjclark - I've just merged in |
Great, thanks very much @chryswoods. No problem at all. |
Thanks - this will take a few hours to build. It should be in the |
Is this pull request to fix a bug, or to introduce new functionality?
Since it was a quick fix, I've updated
analyse_freenrg
to use the pymbar 4 API. I tested on two sets of free energy data before and after the changes and got identical results.devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): ySuggested reviewers:
@chryswoods, @lohedges