Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres.Set to handle PUT; small fixes #57

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

synackd
Copy link
Collaborator

@synackd synackd commented Dec 21, 2024

Addresses #55

This PR adds the Set() method in the postgres package and calls it from the Store() function in BSS when postgres is enabled. The Add() method in postgres is still used in StoreNew().

This PR also adds the following chores and refactorings:

  • Typify postgres errors to be able to determine what type of error occurred
  • Make error messages start with lowercase letter to be more idiomatic
  • Fix phony target in Makefile to be container instead of docker
  • Fix comment typos
  • Fix incorrect 'PATCH' in 'PUT' log message

@synackd synackd linked an issue Dec 21, 2024 that may be closed by this pull request
Copy link
Member

@alexlovelltroy alexlovelltroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexlovelltroy alexlovelltroy merged commit 45f42a5 into main Jan 8, 2025
3 checks passed
@alexlovelltroy alexlovelltroy deleted the synackd/fix-put branch January 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PUT http request not replacing/updating the entity
2 participants