Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Store/Component interface #185

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Add Store/Component interface #185

merged 6 commits into from
Nov 19, 2024

Conversation

Yiling-J
Copy link
Member

Introduce interfaces for all stores and components, enabling easier mocking and more efficient test writing.

@starship-github
Copy link

🚀 The StarShip CodeReviewer has been triggered with action(s): review, evaluate, describe, linter.

@starship-github
Copy link

Linter Issue Report

During the code review, a list issues were found. These issues could affect the code quality, maintainability, and consistency. Below is the detailed Linter issue report:

builder/store/database/access_token.go

Lint Issue: undefined: times

  • Location: Line 50
  • Code Context:
    ExpiredAt   time.Time            `bun:",nullzero" json:"expired_at"`
    times
  • Actionable Suggestion:
    It appears that there's an undefined identifier times at the end of the AccessToken struct. If times is intended to be a comment, ensure it starts with // to make it a proper comment. If it's supposed to be a field or part of the struct, please define it correctly with its type and any struct tags if necessary. For example, if times is meant to be a timestamp, you might want to define it as follows:
    Times time.Time `bun:"type:timestamp" json:"times"`
    Otherwise, if times is not needed, simply remove the line.

Please make the suggested changes to improve the code quality.

@Yiling-J Yiling-J merged commit 0745f31 into main Nov 19, 2024
0 of 4 checks passed
@Yiling-J Yiling-J deleted the feature/interface_refactor branch November 19, 2024 05:55
@starship-github
Copy link

The StarShip CodeReviewer was triggered but terminated because it encountered an issue: The MR state is not opened.

Tips

CodeReview Commands (invoked as MR or PR comments)

  • @codegpt /review to trigger an code review.
  • @codegpt /evaluate to trigger code evaluation process.
  • @codegpt /describe to regenerate the summary of the MR.
  • @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
  • @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

  • Review comments: Directly reply to a review comment made by StarShip.
    Example:
    • @codegpt How to fix this bug?
  • Files and specific lines of code (under the "Files changed" tab):
    Tag @codegpt in a new review comment at the desired location with your query.
    Examples:
    • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

  • Visit our Documentation
    for detailed information on how to use Starship CodeReview.

ganisback pushed a commit that referenced this pull request Dec 5, 2024
* generate store interface

* refactor components and handlers

* add lint/test ci

* update lint timeout

* update lint ci

* update lint ci

---------

Co-authored-by: yiling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants