-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed tests and add more tests #191
Conversation
🚀 The |
Linter Issue ReportDuring the code review, a list issues were found. These issues could affect the code quality, maintainability, and consistency. Below is the detailed Linter issue report: builder/sensitive/aliyun_green.goLint Issue: undefined: SensitiveChecker
Lint Issue: undefined: CheckResult
Lint Issue: undefined: Scenario
Lint Issue: undefined: Scenario
Lint Issue: undefined: CheckResult
Lint Issue: undefined: CheckResult
builder/store/database/access_token.goLint Issue: undefined: defaultDB
common/tests/testutils.goLint Issue: undefined: testcontainers
Lint Issue: undefined: testcontainers
Lint Issue: undefined: testcontainers
Please make the suggested changes to improve the code quality. |
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
* update db tests * fix existing failed tests and add more tests
No description provided.