[ImportFileYARA]: Create an import file connector dedicated to import YARA files/rules #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-filigran
added
the
filigran team
flavienSindou
requested review from
flavienSindou
and removed request for
SamuelHassine
flavienSindou
approved these changes
Feb 3, 2025
Comment on lines
+14
to
+17
| # Expose and entrypoint | ||
| COPY entrypoint.sh / | ||
| RUN chmod +x /entrypoint.sh | ||
| ENTRYPOINT ["/entrypoint.sh"] |
There was a problem hiding this comment.
Suggested change
| # Expose and entrypoint | |
| COPY entrypoint.sh / | |
| RUN chmod +x /entrypoint.sh | |
| ENTRYPOINT ["/entrypoint.sh"] | |
| CMD ["python", "import-file-yara.py"] |
| @@ -0,0 +1,3 @@ | |||
| pycti==6.4.5 | |||
| typing-extensions==4.12.2 | |||
There was a problem hiding this comment.
this does not seems to be used.
Comment on lines
+92
to
+95
| """ | ||
| :param content: | ||
| :return: | ||
| """ |
Comment on lines
+42
to
+46
| :param yara_rule: | ||
| :param yara_name: | ||
| :param yara_metadata: | ||
| :return: | ||
| """ |
helene-nguyen
force-pushed
the
issue/3235
branch
from
db61c01 to
8123a77
Compare
|
@romain-filigran Some comments was added by @flavienSindou (thank you for the review), it will be merged as no blockers found but the connector can be improved later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
New internal import connector that handle .yar file.
Related issues
Checklist