Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for updating existing vulnerabilities #3316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

security-penguin
Copy link

80 and 100 are the same confidence level (1- Confirmed by other sources) but if the score is already at 100 the hardcoded 80 prevents the object being updated.

Passing the update=True is also required to update existing vulnerabilities, otherwise this connector has to create the vulnerability and won't update exisiting vulnerabilities.

Proposed changes

  • Change the hardcoded 80 confidence value to 100 to ensure all existing entries can be updated.
  • Added update=True so that exisiting vulnerabilities will be updated

Related issues

Checklist

  • [ x] I consider the submitted work as finished
  • [ x] I tested the code for its functionality using different use cases
  • [x ] I added/update the relevant documentation (either on github or on notion)
  • [ x] Where necessary I refactored code to improve the overall quality

Further comments

80 and 100 are the same confidence level (1- Confirmed by other sources) but if the score is already at 100 the hardcoded 80 prevents the object being updated.

Passing the update=True is also required to update existing vulnerabilities, otherwise this connector has to create the vulnerability and won't update exisiting vulnerabilities.
@helene-nguyen helene-nguyen added the community use to identify PR from community label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants