Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] reset searchTerm when highlighting changes in content mapping (#9520) #9591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jan 14, 2025

Proposed changes

  • now use a local search state in ContainerAddStixCoreObjects when used for mapping, instead of using local storage

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec marked this pull request as ready for review January 14, 2025 11:18
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.23%. Comparing base (f7549fc) to head (6a47bc5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9591   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files         630      630           
  Lines       60181    60181           
  Branches     6739     6742    +3     
=======================================
  Hits        39261    39261           
  Misses      20920    20920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search feature in content mapping view does not search for highlighted text
1 participant