Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/op 75/primary top nav refactor #356

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Feature/op 75/primary top nav refactor #356

merged 3 commits into from
Oct 23, 2023

Conversation

lencodes
Copy link
Contributor

@lencodes lencodes commented Oct 23, 2023 •
edited
Loading

This pull request implements the updated Primary Top Nav from @conduction/components.

This pull request is required before merging this.

@lencodes lencodes requested a review from remko48 October 23, 2023 11:06
remko48
remko48 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@remko48 remko48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Before merging please fix the builds, I think it has to do with your package-lock.json

@lencodes lencodes merged commit ea37def into development Oct 23, 2023
@lencodes lencodes deleted the feature/OP-75/primary-top-nav-refactor branch October 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remko48 remko48 remko48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lencodes @remko48