Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add shortcuts for tools #477

Closed
wants to merge 1 commit into from

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Matthew J. Milner <[email protected]>
@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Feb 23, 2024

Simply calling glWidget->setActiveTool is clearly not enough, either MainWindow::toolActivated() needs to be called or MainWindow::setActiveTool().

However:

  1. Both have very similar code so I'm not sure which needs to be called?
  2. I can't currently work out how to get either in scope.

Help appreciated! :(

@ghutchis
Copy link
Member

But it's already there?

action->setShortcut(QKeySequence(QString("Ctrl+%1").arg(index)));

@matterhorn103
Copy link
Contributor Author

I guess I originally looked only in avogadrolibs. Thanks for pointing that out before letting me sink even more time into it 😶

@matterhorn103 matterhorn103 deleted the shortcuts branch February 24, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants