Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTOSAVE FEATURE (#182) #486

Closed
wants to merge 2 commits into from
Closed

AUTOSAVE FEATURE (#182) #486

wants to merge 2 commits into from

Conversation

vinayakjeet
Copy link

WIP (#182 )
Title: Implement Autosave Feature for Avogadro

Description:
This pull request introduces a new autosave feature to the Avogadro application. The feature aims to enhance user experience by automatically saving the current molecule document at a specified interval, reducing the risk of data loss in case of unexpected application closure. The implementation includes setting up an autosave interval with QTimer, determining the autosave directory based on the application data location, and saving the document in the CJSON format. This autosave functionality is careful to activate only if there are unsaved changes, ensuring efficient use of resources and avoiding unnecessary writes. The feature also involves updates to the MainWindow class to incorporate autosave setup and execution logic. This addition is expected to provide a safety net for users, securing their work without requiring manual intervention for frequent saves.

Signed-off-by: vinayakjeet [email protected]

Introduced autosave functionality in mainwindow.h, defining the necessary slots and variables to support periodic saving of user work. This enhances data integrity and user experience by minimizing potential loss of work.

Signed-off-by: vinayakjeet <[email protected]>
….com>

This update enhances the Avogadro application with an autosave feature, ensuring users' progress is periodically saved to mitigate data loss risks. The implementation involves the creation of a QTimer to trigger autosave actions every 5 minutes, alongside logic to identify changes and execute saves efficiently. This feature is incorporated within the MainWindow class, utilizing the CJSON format for file saving. The approach optimizes resource usage by activating autosave only when necessary, providing a seamless and secure user experience.

Signed-off-by: vinayakjeet <[email protected]>
@vinayakjeet
Copy link
Author

Hello mentors @ghutchis , the pull request is failing due to non-compliance with DCO format despite adhering to the guidelines in the commit message line adjustments. Seeking guidance on resolving this issue efficiently. Thank you

@vinayakjeet vinayakjeet closed this by deleting the head repository Mar 27, 2024
@matterhorn103
Copy link
Contributor

Easiest thing for me when I had the same issue was just to make a fresh branch, make the same changes to the code, and make a new git commit. Signing off is very easy once you know how, just make sure use the -s flag for every commit e.g. git commit -s -m "Commit message."

As far as I can remember you effectively agree to the DCO by signing off commits like this and you don't need to do anything else.

Then you can open a new pull request from the new branch and the DCO check will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants