Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name according to the XDG standard, harmonize metadata with flatpak #517

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@matterhorn103
Copy link
Contributor Author

This is with the aim of no longer having to maintain separate versions for the flatpak but instead having a single source of truth.

Changes to avogadroapp/flatpak (probable removal) will come in a future PR.

@matterhorn103
Copy link
Contributor Author

This is with the aim of no longer having to maintain separate versions for the flatpak but instead having a single source of truth.

Changes to avogadroapp/flatpak (probable removal) will come in a future PR.

@ghutchis
Copy link
Member

Is this WIP or ready to review?

@matterhorn103
Copy link
Contributor Author

I think ready but I don't know if the files that have been renamed are hard-coded in the workflows for the AppImage bundling?

@matterhorn103
Copy link
Contributor Author

flathub/org.openchemistry.Avogadro2#172 is blocked until this goes through, but that doesn't mean it needs to be rushed necessarily. I can look at this more next week. Not really sure why the test builds immediately failed either.

@ghutchis ghutchis merged commit 40d89ee into OpenChemistry:master Oct 31, 2024
32 of 41 checks passed
@avo-bot
Copy link

avo-bot commented Oct 31, 2024

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/october-2024-live-updates/6373/1

@ghutchis
Copy link
Member

The test builds for avogadroapp need some love (i.e., migrating the actions from avogadrolibs back here). I'll do that over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants