Better to use template specialization

Signed-off-by: Geoff Hutchison <[email protected]>
OpenChemistry · Dec 4, 2023 · 1260e1a · 1260e1a
1 parent 27c14a5
commit 1260e1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/avogadro/core/variant-inline.h b/avogadro/core/variant-inline.h
@@ -21,11 +21,13 @@ inline Variant::Variant(T v) : m_type(Null)
   setValue(v);
 }
 
+template <>
 inline Variant::Variant(const char* v) : m_type(String)
 {
   m_value.string = new std::string(v);
 }
 
+template <>
 inline Variant::Variant(const MatrixXf& v) : m_type(Matrix)
 {
   MatrixX* m = new MatrixX(v.rows(), v.cols());

diff --git a/avogadro/core/variant.h b/avogadro/core/variant.h
@@ -48,12 +48,6 @@ class AVOGADROCORE_EXPORT Variant
   template <typename T>
   Variant(T value);
 
-  /** Creates a std::string variant to store @p value */
-  Variant(const char* value);
-
-  /** Creates a MatrixX variant to store @p value */
-  Variant(const MatrixXf& value);
-
   /** Creates a new copy of @p variant. */
   inline Variant(const Variant& variant);