Fix Codacy warning about initializer

Signed-off-by: Geoff Hutchison <[email protected]>
OpenChemistry · Nov 19, 2024 · 7aa46e3 · 7aa46e3
1 parent adee243
commit 7aa46e3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/avogadro/rendering/arrowgeometry.cpp b/avogadro/rendering/arrowgeometry.cpp
@@ -41,16 +41,16 @@ class ArrowGeometry::Private
   ShaderProgram program;
 };
 
-ArrowGeometry::ArrowGeometry() : m_dirty(false), d(new Private)
+ArrowGeometry::ArrowGeometry()
+  : m_dirty(false), d(new Private), m_color(0, 255, 0)
 {
-  m_color = Vector3ub(0, 255, 0);
 }
 
 ArrowGeometry::ArrowGeometry(const ArrowGeometry& other)
   : Drawable(other), m_vertices(other.m_vertices),
-    m_lineStarts(other.m_lineStarts), m_dirty(true), d(new Private)
+    m_lineStarts(other.m_lineStarts), m_color(other.m_color), m_dirty(true),
+    d(new Private)
 {
-  m_color = other.m_color;
 }
 
 ArrowGeometry::~ArrowGeometry()