Skip to content

Commit

Permalink
Ensure MacOS binary packages are built (#1708)
Browse files Browse the repository at this point in the history
* Make sure packages are built on Mac

Signed-off-by: Geoff Hutchison <[email protected]>

* Fixup CentOS archives to build wheels

Signed-off-by: Geoff Hutchison <[email protected]>

---------

Signed-off-by: Geoff Hutchison <[email protected]>
  • Loading branch information
ghutchis authored Sep 11, 2024
1 parent eb01201 commit 9083a95
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ jobs:
fi # password exists
- name: Create Mac and Windows Packages
if: matrix.config.os == 'windows-latest' || matrix.config.os == 'macos-latest'
if: matrix.config.os == 'windows-latest' || runner.os == 'macOS'
shell: bash
run: |
if [ -z "${P12_PASSWORD}" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
# Need to do some setup before repairing the wheel on linux...
CIBW_REPAIR_WHEEL_COMMAND_LINUX: bash scripts/github-actions/repair_command_linux.sh

CIBW_BEFORE_ALL_LINUX: yum install -y git eigen3-devel
CIBW_BEFORE_ALL_LINUX: bash scripts/github-actions/repair-linux.sh

# Specify eigen location for windows
CIBW_ENVIRONMENT_WINDOWS: "EXTRA_CMAKE_ARGS=-DEIGEN3_INCLUDE_DIR:PATH=/c/eigen"
Expand Down
11 changes: 11 additions & 0 deletions scripts/github-actions/repair-linux.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env bash
set -ev

# CentOS 7 is EOL so mirror.centos.org is offline
# https://serverfault.com/a/1161921

sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo
sed -i s/^#.*baseurl=http/baseurl=https/g /etc/yum.repos.d/*.repo
sed -i s/^mirrorlist=http/#mirrorlist=https/g /etc/yum.repos.d/*.repo

yum install -y git eigen3-devel

0 comments on commit 9083a95

Please sign in to comment.