Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving code efficiency by errors from cppcheck #1369

Closed
wants to merge 14 commits into from
Closed

Improving code efficiency by errors from cppcheck #1369

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
79eab9e
Added explicit keyword infront of the constructor, to prevent it from…
Surajjalpun2002 Oct 11, 2023
171ae1b
Removed a unnecessary part of the code
Surajjalpun2002 Oct 11, 2023
1dda8a5
cppcheck warning about pointer 'd' having no new allocated memory
Surajjalpun2002 Oct 12, 2023
2339bab
cppcheck warning about pointer 'd' having no new allocated memory
Surajjalpun2002 Oct 12, 2023
68d64b9
commented out Unused private function: 'Variant::lexical_cast
Surajjalpun2002 Oct 12, 2023
7dc0699
Merge branch 'master' of https://github.com/Surajjalpun2002/avogadrolibs
Surajjalpun2002 Oct 12, 2023
39377a1
Class 'Variant' has a constructor with 1 argument that is not explicit
Surajjalpun2002 Oct 12, 2023
271779c
undid one of the earlier commits
Surajjalpun2002 Oct 12, 2023
e274319
undid one of the earlier commits
Surajjalpun2002 Oct 12, 2023
d9a5bc4
Merge branch 'master' of https://github.com/Surajjalpun2002/avogadrolibs
Surajjalpun2002 Oct 13, 2023
b8dfd52
added explicit infront of constructors to prevent it from being used …
Surajjalpun2002 Oct 13, 2023
196e78d
undid another changes
Surajjalpun2002 Oct 13, 2023
f3ad4b6
undid another change
Surajjalpun2002 Oct 14, 2023
b9f6d61
Merge branch 'OpenChemistry:master' into master
Surajjalpun2002 Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions avogadro/core/variant.h
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this commit somehow has message from the previous commit, but changes in it are for the just next commit about removing unused private function

Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,9 @@ class AVOGADROCORE_EXPORT Variant

private:
template <typename T>
static T lexical_cast(const std::string& string);
// static T lexical_cast(const std::string& string);

private:
Type m_type;
private : Type m_type;
union
{
bool _bool;
Expand All @@ -146,8 +145,8 @@ class AVOGADROCORE_EXPORT Variant
} m_value;
};

} // end Core namespace
} // end Avogadro namespace
} // namespace Core
} // namespace Avogadro

#include "variant-inline.h"

Expand Down