Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for reading imaginary vibrational frequencies in ORCA outputs. #1398

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dtelsing
Copy link
Contributor

When reading an ORCA output file with an imaginary mode (which have an imaginary mode comment in the frequency line), the line and subsequent lines are skipped. This leads to an out-of-bounds access when reading normal modes, the IR spectrum or the Raman spectrum, as the indices read from the file are not verified.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@welcome
Copy link

welcome bot commented Oct 23, 2023

Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests.

@dtelsing dtelsing force-pushed the orca_imaginary_freq branch from f7a0062 to 22e88ce Compare October 23, 2023 20:51
avogadro/quantumio/orca.cpp Show resolved Hide resolved
avogadro/quantumio/orca.cpp Outdated Show resolved Hide resolved
avogadro/quantumio/orca.cpp Show resolved Hide resolved
@ghutchis
Copy link
Member

Great, thanks! I obviously haven't dealt with many TS or imaginary modes and was largely porting the "Orca-enhanced Avogadro 1.2" code.

@ghutchis
Copy link
Member

The CMake build failure on Ubuntu / GCC seems like a problem on that build node. I'll restart in an hour or two. (There are lots of new PR, so each is taking a while.)

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

If you can make the minor changes I mentioned, I'm happy to merge this ASAP. Thanks!

@dtelsing dtelsing force-pushed the orca_imaginary_freq branch from 22e88ce to 903c5c5 Compare October 24, 2023 18:31
They are marked by ***imaginary mode*** after the frequency.
Also, abort reading normal modes, the IR or the Raman spectrum if an
invalid index was found.

Signed-off-by: David Elsing <[email protected]>
@dtelsing dtelsing force-pushed the orca_imaginary_freq branch from 903c5c5 to 603d465 Compare October 24, 2023 18:35
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit 559b915 into OpenChemistry:master Oct 24, 2023
18 checks passed
@welcome
Copy link

welcome bot commented Oct 24, 2023

Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone!

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants