Add "…" indicator for display types with settings #1541
Conversation
Fix OpenChemistry#1529 Signed-off-by: Geoff Hutchison <[email protected]>
|
Full change requires a patch to avogadroapp too. |
|
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/december-2023-live-updates/5051/1 |
|
Final version looks like this: Thoughts @matterhorn103 |
|
Here are the build results |
@ghutchis Personally I think that looks great and works well! Makes the extra settings much more discoverable. You? The only thing I will say is that normally three Unicode bullets ••• get used in UI design, so they're fatter and on the median not the baseline, not an ellipsis … Is using the Unicode possible? Presumably, since a true ellipsis character is used in the menus. |
|
That's not even Unicode - bullets are part of the normal 255 characters. Can you post a screenshot of something similar? Thanks |
Signed-off-by: Geoff Hutchison <[email protected]>
|
Examples from Github, Spotify, OneNote, WhatsApp, and the iPhone notes app. All middle-aligned, not on the baseline.
|
|
Here are the build results |
Fix #1529
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.