Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake: Remove custom Find<Package>.cmake modules #1585

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Cmake: Remove custom Find<Package>.cmake modules #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69601db
Remove custom FindEigen3
LecrisUT Jan 25, 2024
836ecb2
Remove custom FindSPGLIB
LecrisUT Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ if (NOT SKBUILD)
install(FILES
"${AvogadroLibs_BINARY_DIR}/AvogadroLibsConfig.cmake"
"${AvogadroLibs_BINARY_DIR}/AvogadroLibsConfigVersion.cmake"
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindEigen3.cmake"
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/Findlibmsym.cmake"
DESTINATION "${INSTALL_LIBRARY_DIR}/cmake/avogadrolibs")
install(EXPORT "AvogadroLibsTargets"
Expand Down
4 changes: 2 additions & 2 deletions avogadro/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ if(NOT PYTHON_WHEEL_BUILD)
endif()

if(USE_SPGLIB)
find_package(SPGLIB REQUIRED)
find_package(Spglib REQUIRED)
avogadro_headers(Core avospglib.h)
target_sources(Core PRIVATE avospglib.cpp)
target_link_libraries(Core PRIVATE spglib::spglib)
target_link_libraries(Core PRIVATE Spglib::symspg)
endif()

# The std::shared_mutex class needs pthreads on Linux.
Expand Down
33 changes: 0 additions & 33 deletions cmake/FindEigen3.cmake
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions cmake/FindSPGLIB.cmake
View file
Open in desktop

This file was deleted.

Loading