Added fog as rendering options. #1672
Conversation
Signed-off-by: Perminder <[email protected]>
|
The fog is functioning well, but there's still a bit of work left to complete in this PR. I will update it soon, and a complementary PR will be coming shortly in the Avogadroapp repository. If anyone is interested in reviewing this PR, please take a look and provide feedback. Thanks:)
|
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
|
Here are the build results |
Signed-off-by: Perminder <[email protected]>
simplescreenrecorder-2024-06-24_04.27.11.mp4simplescreenrecorder-2024-06-24_04.29.32.mp4simplescreenrecorder-2024-06-24_04.35.46.mp4So, I think its complete now. Here's the result for fog. Anyone reviews are highly appreciated. Thankyou :) |
|
Here are the build results |
|
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: |
Signed-off-by: Perminder Singh <[email protected]>
Signed-off-by: Perminder Singh <[email protected]>
|
Thanks @ghutchis for the review, I have made the changes you mentioned, also I have tested it and it's working well. Thanks :) |
|
Here are the build results |
|
Okay, the failures look unrelated - I'm going to merge this. |
|
Thank you for merging this in! |
|
Here are the build results |
issue : #347
Signed-off by : [email protected]
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.