Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MacOS binary packages are built #1708

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Ensure MacOS binary packages are built #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44d5754
Check on Mac DMG binary
ghutchis Sep 11, 2024
14ab300
Make sure packages are built on Mac
ghutchis Sep 11, 2024
2ed42f1
Fixup CentOS archives to build wheels
ghutchis Sep 11, 2024
9fed804
Switch tmate back to if failure
ghutchis Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ jobs:
fi # password exists

- name: Create Mac and Windows Packages
if: matrix.config.os == 'windows-latest' || matrix.config.os == 'macos-latest'
if: matrix.config.os == 'windows-latest' || runner.os == 'macOS'
shell: bash
run: |
if [ -z "${P12_PASSWORD}" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
# Need to do some setup before repairing the wheel on linux...
CIBW_REPAIR_WHEEL_COMMAND_LINUX: bash scripts/github-actions/repair_command_linux.sh

CIBW_BEFORE_ALL_LINUX: yum install -y git eigen3-devel
CIBW_BEFORE_ALL_LINUX: bash scripts/github-actions/repair-linux.sh

# Specify eigen location for windows
CIBW_ENVIRONMENT_WINDOWS: "EXTRA_CMAKE_ARGS=-DEIGEN3_INCLUDE_DIR:PATH=/c/eigen"
Expand Down
11 changes: 11 additions & 0 deletions scripts/github-actions/repair-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env bash
set -ev

# CentOS 7 is EOL so mirror.centos.org is offline
# https://serverfault.com/a/1161921

sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo
sed -i s/^#.*baseurl=http/baseurl=https/g /etc/yum.repos.d/*.repo
sed -i s/^mirrorlist=http/#mirrorlist=https/g /etc/yum.repos.d/*.repo

yum install -y git eigen3-devel
Loading