Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatpak workflow for GitHub Actions #1772

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Contributor

Here are the build results
macOS.dmg
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

It's giving this error:

** (flatpak-builder:1007): ERROR **: 17:44:23.944: 
Failed to load included manifest (/__w/avogadrolibs/avogadrolibs/avogadroapp/flatpak/shared-modules/glew/glew.json): 
Failed to open file ?/__w/avogadrolibs/avogadrolibs/avogadroapp/flatpak/shared-modules/glew/glew.json?: No such file or directory

@matterhorn103
Copy link
Contributor Author

Yep I saw. It's looking for the shared module relative to the path of the manifest and not to the root.

I could open a PR to keep the manifest in the top level of openchemistry (many projects do this), but then I would have to find a way to overwrite that manifest when building the release flatpaks.

I've added a step that manually moves the manifest up to the openchemistry top level, and I'm hoping that does the trick, as the source tree is then set up identically to the normal flatpak builds then I think?

@matterhorn103
Copy link
Contributor Author

This is blocked by OpenChemistry/avogadroapp#523 as it relies on the new manifest being in the correct location, so the build won't succeed just yet.

@matterhorn103 matterhorn103 changed the title Add flatpak workflow for GitHub Actions WIP: Add flatpak workflow for GitHub Actions Nov 11, 2024
@avo-bot
Copy link

avo-bot commented Nov 11, 2024

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/november-2024-live-updates/6446/1

Copy link
Contributor

Here are the build results
Win64.exe
Artifacts will only be retained for 90 days.

@matterhorn103 matterhorn103 changed the title WIP: Add flatpak workflow for GitHub Actions Add flatpak workflow for GitHub Actions Nov 13, 2024
Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

Let me know when this is ready for review, thanks.

@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Nov 13, 2024

@ghutchis Now that the other PR has been merged, this should be ready now!

Signed-off-by: Matthew J. Milner <[email protected]>
Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit 13450ae into OpenChemistry:master Nov 14, 2024
23 checks passed
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants