Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow semi-transparent ball-and-sticks and vdw rendering #1783

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

ghutchis
Copy link
Member

Will eventually be set based on the layer

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Will eventually be set based on the layer

Signed-off-by: Geoff Hutchison <[email protected]>
@ghutchis ghutchis linked an issue Nov 14, 2024 that may be closed by this pull request
@avo-bot
Copy link

avo-bot commented Nov 14, 2024

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/november-2024-live-updates/6446/1

Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

avogadro/qtplugins/ballandstick/ballandstick.cpp Dismissed Show dismissed Hide dismissed
avogadro/qtplugins/ballandstick/ballandstick.cpp Dismissed Show dismissed Hide dismissed
Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Signed-off-by: Geoff Hutchison <[email protected]>
@ghutchis ghutchis changed the title WIP: Allow semi-transparent ball-and-sticks and vdw rendering Allow semi-transparent ball-and-sticks and vdw rendering Nov 14, 2024
@ghutchis ghutchis added enhancement feature changes / API changes rendering labels Nov 14, 2024
Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

{
m_opacity = static_cast<float>(opacity) / 100.0f;
auto* interface = m_layerManager.getSetting<LayerVdW>();
if (m_opacity != interface->opacity) {

Check notice

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.
Copy link
Contributor

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit ad91707 into OpenChemistry:master Nov 15, 2024
22 of 23 checks passed
@ghutchis ghutchis deleted the translucent-vdw branch November 15, 2024 21:17
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partially transparent layers
2 participants