-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Qt patch version and install-qt-action v4 in Qt6 Action #1841
Update to latest Qt patch version and install-qt-action v4 in Qt6 Action #1841
Conversation
Signed-off-by: Matthew J. Milner <[email protected]>
Qt 6.8.0 -> 6.8.1, which has a lot of fixes. Also bumped the version of the There is an upgrade guide for The default settings in v4 and with Qt 6.8 align with the Windows-specific settings we had before so I dropped the separate step for Windows as it's now superfluous. If everything looks good and merging is approved I'll update the |
@ghutchis I don't know anything about building on Mac – should we also be thinking about updating |
Here are the build results |
In priniciple I agree with the update of |
Signed-off-by: Matthew J. Milner <[email protected]>
Here are the build results |
LGTM. I don't know what's going on with CodeQL, but that's not related. |
Here are the build results |
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/december-2024-live-updates/6609/1 |
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.