Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize workflows #1869

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Matthew J. Milner <[email protected]>
@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Dec 16, 2024

This in part is continuing recent changes.

  • Separate workflow matrices for Windows, macOS, Linux, Flatpak
  • Got rid of the old CMake and Qt6 matrices altogether, moved the workflows we still need into the OS-based workflows
  • Release builds on Linux are Qt6
  • Uniformity of:
    • Workflow names
    • Artifact names (script or workflow for uploads of Nightly builds will need updating)
    • Environment variables
    • Build flags
    • Steps
  • Identical workflows between avogadroapp and avogadrolibs

Signed-off-by: Matthew J. Milner <[email protected]>
Signed-off-by: Matthew J. Milner <[email protected]>
Signed-off-by: Matthew J. Milner <[email protected]>
Signed-off-by: Matthew J. Milner <[email protected]>
Signed-off-by: Matthew J. Milner <[email protected]>
@matterhorn103
Copy link
Contributor Author

The macOS Intel build fails due to some issue with the packaging step, which I'll look into (it should run identically to the current Mac release builds so it ought to work fine).

The two builds on macos-latest i.e. M1 CPUs fail at the VTK step. @ghutchis does VTK not normally compile fine on your Mac?

@ghutchis
Copy link
Member

Mac builds sometimes fail when it tries to create the DMG file. It's a known bug with CI builds. You can either set up a retry loop or upgrade to a newer macOS - although even then...

I'm definitely wondering if we should just have a zipped Mac app, which is the other common way to distribute Mac apps and would definitely be easier.

I've got a bunch going on today, but I'll get back to this when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants