Link publicly against Qt6::OpenGLWidgets

[nicolasfella]

The public glwidget.h header uses it, so the link must be public

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

[github-actions]

Here are the build results
Ubuntu-Latest.tar.gz
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

[ghutchis]

At least on the GitHub builds (not sure of CMake version) this is failing due to find_dependency

e.g., it builds avogadrolibs just fine, then fails with avogadroapp when it uses the resulting package:

CMake Error at /home/runner/work/avogadrolibs/build/prefix/lib/cmake/avogadrolibs/AvogadroLibsConfig.cmake:23 (find_dependency):
  Unknown CMake command "find_dependency".
Call Stack (most recent call first):
  avogadro/CMakeLists.txt:3 (find_package)

IIRC, you'll also need to add include(CMakeFindDependencyMacro) at the top.

Otherwise, LGTM.

[nicolasfella]

At least on the GitHub builds (not sure of CMake version) this is failing due to find_dependency

e.g., it builds avogadrolibs just fine, then fails with avogadroapp when it uses the resulting package:

CMake Error at /home/runner/work/avogadrolibs/build/prefix/lib/cmake/avogadrolibs/AvogadroLibsConfig.cmake:23 (find_dependency):
  Unknown CMake command "find_dependency".
Call Stack (most recent call first):
  avogadro/CMakeLists.txt:3 (find_package)

IIRC, you'll also need to add include(CMakeFindDependencyMacro) at the top.

Otherwise, LGTM.

fixed

[github-actions]

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

[ghutchis]

LGTM - many thanks!

[github-actions]

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.