Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for reading AMBER mdcrd trajectories #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

badarsh2
Copy link
Collaborator

@badarsh2 badarsh2 commented Aug 8, 2018

Re-request of PR #287 created earlier.
I messed up with the previous PR while rebasing, so I've created one afresh.

Approach: Since the mdcrd datatype is merely a huge sequence of floats, I'm initially reading them an storing them in the molecule class as a coordinate set. Then I invoke the custom gui dialog here in mainwindow which gets the numAtoms from the user. Appropriately, the atoms are then added, and the scene is set.

Though the implementation not quite elegant, it does the required job straightforwardly. Suggestions for improvements are welcome.


Signed-off-by: Adarsh Balasubramanian [email protected]

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Adarsh Balasubramanian <[email protected]>
@cryos
Copy link
Member

cryos commented Aug 29, 2018

This seems to have unrelated changes adding a molecule information dialog. It would be good to separate that out.

@ghutchis
Copy link
Member

@cryos - the dialog seems related to resolving the mdcrd trajectories - which I think just include coordinates, not atom/bond assignments.

This is old, but I'm okay merging.

@ghutchis ghutchis added enhancement feature changes / API changes file-format relevant to IO file formats labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes file-format relevant to IO file formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants