-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for constraints #481
Initial support for constraints #481
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/constraints-in-avogadro2/3072/10 |
I'm on a short trip with the family, but I'll take a look on Wednesday. A few quick notes
|
I'd like to see if I can help you finish this up, particularly as I'm finishing force field code (which could use the freeze atom, etc. bits). Could you take care of the DCO sign-off? If you've got some time to work on it, I'd be happy to help. If not, please take care of the DCO and I can pick it up from here. |
I'll ping again. I'd really like to build on this. Could you please fix the sign-off for the DCO. It should take a minute or two. |
bd44981
to
a834c5c
Compare
Signed-off-by: kantundpeterpan <[email protected]>
Not always great options, but these are error paths Signed-off-by: Geoff Hutchison <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
We no longer support older compilers that lacked the data method on std::vector, and so we should move to use this standard method. This was brought up in issue OpenChemistry#478 by John Bollinger. Signed-off-by: Marcus D. Hanwell <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: Geoff Hutchison <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: Geoff Hutchison <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/ Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 21.2% (176 of 828 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/nb_NO/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 27.7% (230 of 828 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/pt/ Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: Geoff Hutchison <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 34.4% (393 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/fr/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 34.6% (395 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/fr/ Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: Eric Berquist <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 15.7% (180 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/tr/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 15.7% (180 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/tr/ Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: dvermd <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Signed-off-by: dvermd <[email protected]> Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 26.0% (297 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/ru/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 21.4% (244 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/pt/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 16.0% (183 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/nb_NO/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 26.1% (298 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/ru/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 16.6% (190 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/tr/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 16.4% (188 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/nb_NO/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 23.7% (271 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/pt_BR/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 32.8% (374 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/pt_BR/ Signed-off-by: kantundpeterpan <[email protected]>
Currently translated at 19.6% (224 of 1140 strings) Translation: Avogadro/avogadrolibs Translate-URL: https://hosted.weblate.org/projects/avogadro/avogadrolibs/hu/ Signed-off-by: kantundpeterpan <[email protected]>
a834c5c
to
2904c0a
Compare
Hello. Sorry for the late answer, I was caught up in writing my thesis last year and missed the notifications from here. I signed off the commits. Best |
Thanks. I'll probably cherry-pick your changes into another pull-request, but it'll keep your history and authorship. Might be a few days, but this is really helpful. |
Okay, I rebased this into #841 - I'll go with the merge there, but this is really helpful. Thanks for your contribution! |
ToDo
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.