Fix the calculation notebook view #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view was previously limited to a height of 60px. The notebook height is now determined by the available space. Signed-off-by: Brianna Major <[email protected]>
|
Addresses #150 |
cjh1
reviewed
Oct 29, 2019
src/components/notebook.js
Outdated
| const appStyles = theme => ({ | ||
| iframe: { | ||
| width: '100%', | ||
| height: '-webkit-fill-available' |
There was a problem hiding this comment.
Will this work on non webkit based browser? And do we care ? :-)
There was a problem hiding this comment.
It will not, good point. I've updated the styling to calculate from the size of the notebook instead and this seems to work well in both Chrome and Firefox.
To ensure cross-browser support, calculate the height of the IFrame based on the height of the notebook rather than using webkit styling. Signed-off-by: Brianna Major <[email protected]>
|
@bnmajor This works, but there a bit of delay, while the size is calculated. So it looks like this for a second or so:
Is there a way we could do it with CSS across browsers or hidden the component util the calculation is done. |
Use the notebook aspect ratio to determine padding for the iFrame container. This keeps the proportions of the JupyterLab Notebook, avoids the delay caused by calculating the height, and seems to work smoothly across browsers. Signed-off-by: Brianna Major <[email protected]>
cjh1
reviewed
Nov 14, 2019
src/components/notebook.js
Outdated
| container: { | ||
| overflow: 'hidden', | ||
| position: 'relative', | ||
| paddingTop: '72%' |
There was a problem hiding this comment.
Let give ourselves a little more height and increase this to 100%
Signed-off-by: Brianna Major <[email protected]>
cjh1
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view was previously limited to a height of 60px. The notebook height is now
determined by the available space.
Signed-off-by: Brianna Major [email protected]