-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flyback #304
Merged
Merged
Remove flyback #304
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
529e7f0
Add the ability to remove the flyback column in from_hdf5 function.
89f540f
Add commenting
e77d924
Test for removing flyback
0cc0b27
remove test for initial build
30aa565
Add the ability to remove the flyback column in from_hdf5 function.
ced8336
Add commenting
2db681c
Test for removing flyback
cd5718c
remove test for initial build
50059d2
Merge branch 'remove_flyback' of github.com:ercius/stempy into remove…
77d0ead
scan shape values were reversed. Fix that and delete the correct valu…
7b86740
add proper keyword to load_electron_counts in io.__init__
e3b5dff
remove printing lines.
1bd57a6
add test for removing flyback when loading from HDF5
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to use
ii
for indices? instead ofi
for ex.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never use single letter variables.
I once spent a full day debugging something where
i
was already used forsqrt(-1)
. Ever since, I always useii
,jj
,kk
, etc. for loops.Also, when using the
pdb
debugger,c
,q
,n
, etc. are reserved for interacting with the debugger (continue, quit, next, etc.). That messed me up a few times as well.