-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flyback #304
Remove flyback #304
Changes from 12 commits
529e7f0
89f540f
e77d924
0cc0b27
30aa565
ced8336
2db681c
cd5718c
50059d2
77d0ead
7b86740
e3b5dff
1bd57a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -710,6 +710,13 @@ def compare_with_sparse(full, sparse): | |
assert np.array_equal(m_array[[False, True], 0][0], position_one) | ||
|
||
|
||
def test_keep_flyback(sparse_array_small): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like I started the test but did not finish it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test added |
||
pass | ||
#flyback = SparseArray.from_hdf5(electron_data_small, keep_flyback=True) | ||
#assert flyback.scan_shape[1] == 50 | ||
#no_flyback = SparseArray.from_hdf5(electron_data_small, keep_flyback=True) | ||
#assert flyback.scan_shape[1] == 49 | ||
|
||
# Test binning until this number | ||
TEST_BINNING_UNTIL = 33 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to use
ii
for indices? instead ofi
for ex.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never use single letter variables.
I once spent a full day debugging something where
i
was already used forsqrt(-1)
. Ever since, I always useii
,jj
,kk
, etc. for loops.Also, when using the
pdb
debugger,c
,q
,n
, etc. are reserved for interacting with the debugger (continue, quit, next, etc.). That messed me up a few times as well.