Skip to content

Commit

Permalink
Do not emit data modified after pipeline finishes
Browse files Browse the repository at this point in the history
There is a new datasource every time now, so this is not necessary.
Additionally, this is causing crashing when closing the application
when operators are present, and it is also causing crashing
occasionally when deleting datasources that have operators.

Signed-off-by: Patrick Avery <[email protected]>
  • Loading branch information
psavery committed Apr 9, 2020
1 parent 4482381 commit b4616b7
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions tomviz/PipelineModel.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -777,14 +777,6 @@ void PipelineModel::dataSourceAdded(DataSource* dataSource)
connect(pipeline, &Pipeline::operatorAdded, this,
&PipelineModel::operatorAdded, Qt::UniqueConnection);

// Fire signal to indicate that the transformed data source has been modified
// when the pipeline has been executed.
// TODO This should probably be move else where!
connect(pipeline, &Pipeline::finished, [this, pipeline]() {
auto transformed = pipeline->transformedDataSource();
emit dataSourceModified(transformed);
});

// When restoring a data source from a state file it will have its operators
// before we can listen to the signal above. Display those operators.
foreach (auto op, dataSource->operators()) {
Expand Down

0 comments on commit b4616b7

Please sign in to comment.