Fixed issue #216 "canardMemFree must provide size" #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extended `CanardTxQueueItem` with extra `allocatd_size` field to remember original size allocated for the item (and its embedded payload). - For RX pipeline we always know what was allocated for a payload - it's always equal to session `extent`.
|
pavel-kirienko
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
The examples in the README should be updated to show how to use the new sized deallocations and, most importantly, how not to confuse payload_size and allocated_size.
Please bump the major version number! This would be v4.0
Lines 96 to 97 in 14e373a
Sure, I'll do this. Please note that I'm planning to keep whole this topic (and related to zero-copy issue changes) under temporary v4 branch - until all breaking changes required for this theme are done, and then release 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanardTxQueueItemwith extraallocated_sizefield to remember original size allocated for the item (and its embedded payload).CanardRxTransferwith extraallocated_sizefield to report to the client original size allocated for the payload buffer (which is normally equal to sessionextent).