Fix Build Issues #14
Merged
Fix Build Issues #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- One fix is for OpenSSL that's related to renaming our `ANDROID_NDK` variable in OpenDDS#13. - The other is `configure.sh` assumed it could pass spaces through `--mpcopts`, which changed in OpenDDS/OpenDDS#4574.
mitza-oci
approved these changes
Aug 9, 2024
Also add check to assert that the NDK files we are defining in setenv.sh actually exist.
|
This is also testing OpenDDS/OpenDDS#4763. Once the CI here looks good, the OpenDDS PR can be merged, the temporary override here should be reverted, then this PR can be merged. |
mitza-oci
reviewed
Aug 12, 2024
mitza-oci
approved these changes
Aug 12, 2024
This reverts commit 769c510.
iguessthislldo
force-pushed
the
igtd/build-fixes
branch
from
972a344 to
7e34399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANDROID_NDKvariable in Use ubuntu 22.04, removed support for OCI distribution of ACE/TAO #13.configure.shassumed it could pass spaces through--mpcopts, which changed in--mpcoptsvalues are split on spaces OpenDDS#4574.