Added a option for using statically built opendds. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
requested changes
Oct 5, 2023
CMakeLists.txt
Outdated
| @@ -1,5 +1,6 @@ | |||
| cmake_minimum_required(VERSION 3.20) | |||
|
|
|||
| option(OpenDDWStatic "OpenDDWStatic" OFF) #Build openddw to be compatible with a static build of opendds | |||
There was a problem hiding this comment.
Instead of setting this, you could use OPENDDS_STATIC.
There was a problem hiding this comment.
Is there a way to get this define from a complied opendds library or are you suggesting I just name the option consistently?
There was a problem hiding this comment.
The former, I think. OPENDDS_STATIC is a CMake variable, but if by define you mean a C predecessor macro, then you could use ACE_AS_STATIC_LIBS.
|
Using ACE_AS_STATIC_LIBS was a great idea! I changed it to that. Hopefully this should be good now. I also have a change on opendds-monitor to take a look at. |
doug1234
changed the title
iguessthislldo
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.