helper: ip: avoid using a VLA in a header because of C++ apps

Variable length arrays are not allowed in C++, so do not use one in a header file that may be included by a C++ application. Clang++-18 complains about it, breaking the build. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
OpenDataPlane · Sep 27, 2024 · bd490f1 · bd490f1
1 parent cefac52
commit bd490f1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/helper/include/odp/helper/ip.h b/helper/include/odp/helper/ip.h
@@ -112,7 +112,8 @@ static inline int odph_ipv4_csum(odp_packet_t pkt,
 				 odp_u16sum_t *chksum)
 {
 	uint32_t nleft = (uint32_t)(ODPH_IPV4HDR_IHL(ip->ver_ihl) * 4);
-	uint16_t buf[nleft / 2];
+	const int max_ip_header_len = 15 * 4;
+	uint16_t buf[max_ip_header_len];
 	int res;
 
 	if (odp_unlikely(nleft < sizeof(*ip)))