[PATCH v3] api: pktio: lso: improve the specification of IPv4 and TCP LSO #2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the DF flag handling in TCP segmentation offload and improve the description in general:
Specify that the DF flag of the IP header is to be preserved as it was in the original packet and not cleared as the current spec says.
Specify that TCP segmentation should be done in a way that complies with the TCP standard, without going into details. This entails proper handling of various TCP header flags and TCP options.
Specify that unique ID values are generated for non-atomic datagrams and leave it unspecified how the ID value is updated for atomic datagrams (packets which are not fragments and have the DF flag set). Suggest that an application should avoid sending packets with ID values that may lead to overlapping IDs after segmentation.
Improve the description of IPv4 fragmentation offload. This does not change the meaning of the specification but makes it clear that the DF flag is not affected by LSO and that IP option fields are processed as specified in the standard.