-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH v3] test: sched_latency: improve test queue creation #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
test: sched_latency: improve test queue creation
[PATCH v1] test: sched_latency: improve test queue creation
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the first patch is just simple "move-to-function", up to you if you want to further refactor it based on the first patch comments.
MatiasElo
force-pushed
the
fix/sched_latency
branch
from
November 19, 2024 13:41
c5ebed2
to
a0193a7
Compare
odpbuild
changed the title
[PATCH v1] test: sched_latency: improve test queue creation
[PATCH v2] test: sched_latency: improve test queue creation
Nov 19, 2024
V2:
|
TuomasTaipale
approved these changes
Nov 20, 2024
Refactor queue creation code into a separate function. No other changes than moving the code. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
Refactor queue creation code. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
Configure queue size to make sure queues are large enough to store all test events. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
Check capability for the number of created queues. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
MatiasElo
force-pushed
the
fix/sched_latency
branch
from
November 20, 2024 07:57
a0193a7
to
956c92c
Compare
odpbuild
changed the title
[PATCH v2] test: sched_latency: improve test queue creation
[PATCH v3] test: sched_latency: improve test queue creation
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.