Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v3] test: sched_latency: improve test queue creation #2145

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

MatiasElo
Copy link
Collaborator

No description provided.

@odpbuild odpbuild changed the title test: sched_latency: improve test queue creation [PATCH v1] test: sched_latency: improve test queue creation Nov 13, 2024
Copy link
Collaborator

@TuomasTaipale TuomasTaipale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the first patch is just simple "move-to-function", up to you if you want to further refactor it based on the first patch comments.

test/performance/odp_sched_latency.c Outdated Show resolved Hide resolved
test/performance/odp_sched_latency.c Show resolved Hide resolved
test/performance/odp_sched_latency.c Outdated Show resolved Hide resolved
test/performance/odp_sched_latency.c Outdated Show resolved Hide resolved
test/performance/odp_sched_latency.c Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v1] test: sched_latency: improve test queue creation [PATCH v2] test: sched_latency: improve test queue creation Nov 19, 2024
@MatiasElo
Copy link
Collaborator Author

V2:

  • Added new commit which fixes all review comments

Refactor queue creation code into a separate function. No other changes
than moving the code.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Refactor queue creation code.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Configure queue size to make sure queues are large enough to store all test
events.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Check capability for the number of created queues.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
@odpbuild odpbuild changed the title [PATCH v2] test: sched_latency: improve test queue creation [PATCH v3] test: sched_latency: improve test queue creation Nov 20, 2024
@MatiasElo MatiasElo enabled auto-merge (rebase) November 20, 2024 07:57
@MatiasElo MatiasElo merged commit 0109893 into OpenDataPlane:master Nov 20, 2024
162 checks passed
@MatiasElo MatiasElo deleted the fix/sched_latency branch November 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants