Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v2] test: queue_perf: fix pair mode issues #2148

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

MatiasElo
Copy link
Collaborator

No description provided.

@odpbuild odpbuild changed the title test: queue_perf: fix pair mode issues [PATCH v1] test: queue_perf: fix pair mode issues Nov 15, 2024
Copy link
Collaborator

@TuomasTaipale TuomasTaipale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two commit message improvement suggestions, otherwise looks good:

  • first patch: maybe a comma between "In pair mode" and "events"?
  • second patch: swap "the" and "all" in "... until the all workers ..."?

In pair mode, events may accumulate into one queue, so double the used
queue size.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Keep workers running in pair mode until all the workers have completed
their test rounds. Otherwise workers can get stuck if no one is processing
events in the other end of queue pair.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
@odpbuild odpbuild changed the title [PATCH v1] test: queue_perf: fix pair mode issues [PATCH v2] test: queue_perf: fix pair mode issues Nov 20, 2024
@MatiasElo
Copy link
Collaborator Author

V2:

  • Fixed commit messages and added reviewed-by tags

@MatiasElo MatiasElo enabled auto-merge (rebase) November 20, 2024 07:19
@MatiasElo MatiasElo merged commit ebbad47 into OpenDataPlane:master Nov 20, 2024
162 checks passed
@MatiasElo MatiasElo deleted the fix/queue_perf branch November 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants